Skip to content

Avoid a circular import by moving load_tree into kdtree_generator#2085

Open
kbwestfall wants to merge 9 commits intopypeit:developfrom
kbwestfall:load_kdtree
Open

Avoid a circular import by moving load_tree into kdtree_generator#2085
kbwestfall wants to merge 9 commits intopypeit:developfrom
kbwestfall:load_kdtree

Conversation

@kbwestfall
Copy link
Collaborator

As titled.

Copy link
Collaborator

@rcooke-ast rcooke-ast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

I burned many hours attempting to solve the ThAr automatic wavelength calibration problem, and I think this is not the solution. Perhaps there's a better solution that we could reconsider at some point, but I think for now, perhaps we could raise an error if someone attempts to load a kdtree, to say that this is currently not supported?

@kbwestfall
Copy link
Collaborator Author

This looks good to me 👍

I burned many hours attempting to solve the ThAr automatic wavelength calibration problem, and I think this is not the solution. Perhaps there's a better solution that we could reconsider at some point, but I think for now, perhaps we could raise an error if someone attempts to load a kdtree, to say that this is currently not supported?

Thanks for the quick review, @rcooke-ast ! I added an exception if the user tries to use 'holy-grail' with ThAr arcs. Is this what you were thinking?

@rcooke-ast
Copy link
Collaborator

Precisely, thanks for implementing that!

Copy link
Collaborator

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is nearly deprecated code, but no harm in keeping
it around for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants