Avoid a circular import by moving load_tree into kdtree_generator#2085
Avoid a circular import by moving load_tree into kdtree_generator#2085kbwestfall wants to merge 9 commits intopypeit:developfrom
load_tree into kdtree_generator#2085Conversation
rcooke-ast
left a comment
There was a problem hiding this comment.
This looks good to me 👍
I burned many hours attempting to solve the ThAr automatic wavelength calibration problem, and I think this is not the solution. Perhaps there's a better solution that we could reconsider at some point, but I think for now, perhaps we could raise an error if someone attempts to load a kdtree, to say that this is currently not supported?
Thanks for the quick review, @rcooke-ast ! I added an exception if the user tries to use 'holy-grail' with ThAr arcs. Is this what you were thinking? |
|
Precisely, thanks for implementing that! |
profxj
left a comment
There was a problem hiding this comment.
Indeed, this is nearly deprecated code, but no harm in keeping
it around for now.
As titled.