CoAdd2D now correctly uses manually extracted objects for offsets/weights#2092
Draft
tbowers7 wants to merge 3 commits intopypeit:developfrom
Draft
CoAdd2D now correctly uses manually extracted objects for offsets/weights#2092tbowers7 wants to merge 3 commits intopypeit:developfrom
tbowers7 wants to merge 3 commits intopypeit:developfrom
Conversation
In the Coadd2d process, the input images are rebinned and an attempt is made to refind objects. If the coadd is being done with very low-signal objects, it should be possible to manually extract objects at pre-defined locations and bypass the automated object finding. This is the first step in this direction. modified: pypeit/coadd2d.py modified: pypeit/core/coadd.py modified: pypeit/flatfield.py modified: pypeit/par/parset.py modified: pypeit/par/pypeitpar.py
For code development, add TEST logging level, between INFO and WARNING.
The combination of manual extraction of individual frames and use of the [coadd2d][user_obj_ids] parameter now correctly sets the offets and weights for the desired objects. This allows for manually extracted objects to be correctly coadded even when the object drifts along the slit during a series of exposures. modified: pypeit/coadd2d.py modified: pypeit/core/coadd.py modified: pypeit/core/findobj_skymask.py modified: pypeit/manual_extract.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Clean up the description...
In concert with the Coadd2DPar
user_obj_ids, this PR corrects the CoAdd2D code to pay attention to manually extracted objects when computing offsets and weights.Previously, the coadd2d process would do a full-on object finding, crashing if one of the input frames did not detect objects above the required S/N level. Even if the
user_obj_idsparameter was passed in, the coaddition would not pay attention to the desired object.This PR checks for the presence of
user_obj_idsand essentially performs a manual extraction at the location of the requested objects from this parameter for the purposes of computing offsets and weights only.In the final coadded frame, the object-finding follows the existing paradigm.
In a couple of places, dictionaries were replaced with either
@dataclassobjects or numpy arrays for clarity.Tests to follow.