-
Notifications
You must be signed in to change notification settings - Fork 108
Declare scikit-learn as an optional dependency
#649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare scikit-learn as an optional dependency
#649
Conversation
It is used in the `pyemu.emulators` module, among other places.
scikit-learn as an optional dependencyscikit-learn and graphviz as optional dependencies
|
my feeling is that the graph_pyemu isn't picked up anywhere. Let's check in with @aymanalz, we maybe be able to utilise it or drop graphviz as a dependancy. |
|
Yeah I get the impression that the module there is intended for as a dev tool - to visualize the architecture of the modules. I think it would be helpful to adopt This would allow us to declare lint dependencies etc. (e.g. if Ruff gets added) and so |
|
I have a fork, that is slowly (and tentatively) exploring a move to uv for the whole project, and thus an updated (and more responsible pyproject.toml) https://github.com/briochh/pyemu/tree/feat_uv . perhaps we can bite the bullet on that at some point. |
|
That would be excellent. Probably in that case, we can hold off on declaring |
This reverts commit 467fbe6.
scikit-learn and graphviz as optional dependenciesscikit-learn as an optional dependency
|
Thank you for checking about Graphviz dependency. I do not think I will use this package. |
scikit-learnis used in thepyemu.emulatorsmodule, among other places:pyemu/pyemu/emulators/__init__.py
Lines 47 to 55 in 5dd3c78
graphvizis just used inmisc\graph_pyemu.py.