Revert "reinstate access to QSettings to store ignored version". Fixed compilation on Windows with Qt 5.1.1. Added an option to disable GUI, this time for both Qt 4 and Qt 5.#15
Closed
me21 wants to merge 3 commits intopypt:autoupdatefrom
Conversation
…application author, not library, should decide how to store settings. This reverts commit c76d4bc. Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
…e GUI, this time for both Qt 4 and Qt 5. Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
…ges. Removed unnecessary conditional define for Qt 5 - it compiles fine with #include <QWidget>. Signed-off-by: Alexandr Zarubkin <me21@yandex.ru>
Author
|
Please see new pull request for this: #19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application author, not library, should decide how to store settings. This reverts commit c76d4bc.
This is to fix #14.
Also, fixed compilation on Windows with Qt 5.1.1. Added an option to disable GUI, this time for both Qt 4 and Qt 5. Added automatic recompilation of affected files after GUI option changes. Removed unnecessary conditional define in fvupdatewindow.h for Qt 5 - it compiles fine with #include .