-
-
Notifications
You must be signed in to change notification settings - Fork 405
New tool simple xls ex+import #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tool simple xls ex+import #2873
Conversation
…-simple-xls-ex+import
…le filtering for protected sheet
|
Unable to perform a code review. You have run out of credits 😔 |
...extension/pyRevit.tab/Modify.panel/edit3.stack/Edit.pulldown/XLS Export.pushbutton/script.py
Show resolved
Hide resolved
|
This is can be a great addition to the toolkit. |
|
@Wurschdhaud I really like this addition to pyrevit, it makes parameter manipulation open and accessible to everyone without buying the expensive BIMlink Before getting into clean coding, I downloaded the scripts and I am going to play with them for the next 2 days so I will provide you with some feedback. |
|
No, i needed only the instance paramaters, but thought it might be nice to have type parameters as well. Use I imagined:
since i thought these usecases are quite fixed, i put them in a config, but it might be good to move them to a commandswitch or sth |
el.Symbol.get_Parameter(DB.BuiltInParameter.SYMBOL_NAME_PARAM).AsString() instead of el.Symbol.Name (only for setting?)
- exit without error when aborting
|
Thanks for your input! I like the idea with colorcoding, I'll have to look into the item_template syntax of selectfromlist. As for exporting: I'm now thinking of a config for two options: |
- changed export scope default: now schedule - config mode shift-click will launch advanced, which has different export options
|
@tay0thman |
|
@Wurschdhaud this is awesome, I'll clone the repo in few hours and I will let you my thoughts. Thank you for staying on top of the review. |
|
@Wurschdhaud @tay0thman ready for review? |
|
Fine from myside, just want a second pair of eyes to have a look |
- Added version compatibility checks for parameter data types in both XLS Export and Import scripts. - Improved handling of Yes/No parameters during data export and import processes. - Updated docstrings for clarity on function purposes and return values. - Refined regex pattern for unit postfix matching in the export script.
|
@Wurschdhaud |
|
@jmcouffin I like the way it is headed. I have no further concerns with it, We should be good to merge. I will ask some of my peers, to test it out and we may issue a further PR if there is a bug or a usability issue. Thank you @Wurschdhaud |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+1935-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2011-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25307+2045-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.0.25307+2237-wip |
|
📦 New work-in-progress (wip) builds are available for 5.3.0.25308+0721-wip |
|
📦 New public release are available for 5.3.0.25307+2146 |


Description
I'm proposing a very basic excel ex- and import tool, for users that not need the full functionality of advanced tools like diroots.
Features:
no pretty interface, sticking to library commands and forms for user input.
Checklist
Before submitting your pull request, ensure the following requirements are met:
pipenv run black {source_file_or_directory}Related Issues
If applicable, link the issues resolved by this pull request:
Additional Notes
Include any additional context, screenshots, or considerations for reviewers.
Thank you for contributing to pyRevit! 🎉