-
-
Notifications
You must be signed in to change notification settings - Fork 10
Triangulation inside API #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
+ Coverage 84.07% 93.67% +9.59%
==========================================
Files 39 3 -36
Lines 1212 79 -1133
==========================================
- Hits 1019 74 -945
+ Misses 193 5 -188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks!
Product-wise
Code-wise: can you elaborate on the changes you made to facilitate the review? :) |
For the past few months we have been able to localize fires through triangulation. Until now this code has been running on the platform, but I propose to migrate it to the API because (1) it makes more sense and (2) its migration to the new platform would otherwise be quite complex
The code works as follows:
For all sequences, if they overlap in time and if their detection cones intersect, they potentially represent the same event (Phase 1 in the code)
Once we have candidates, we filter triangulations with more than 2 detections. Since our azimuth estimation is not very precise, 3 sequences may represent the same alert without forming a strict triple intersection (see example image). In this case, we use Phase 2 to accept these triple triangulations within a margin distance