-
Notifications
You must be signed in to change notification settings - Fork 16
Update media, partners, and sponsors sections styling and content #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Improved the layout and responsiveness of the media, partners, and sponsors sections by adding custom CSS for consistent box sizing, alignment, and hover effects. Updated partner and media data in _config.yml, including logo URLs, dimensions, and removed outdated entries. Updated solution images.
Refined the layout and styling for media, partners, and sponsors sections, adjusting paddings and image heights for better visual consistency. Updated _config.yml to improve / shorten partner and sponsor descriptions and fixed translation content. Added a local image for Sécurité&Défense Magazine and updated the Catalonia flag image and its display size to fit better with other flags. Cleaned code in open-data.html file to start correcting a bug with bolded text (still pending).
|
Hello @allezalex the alignment is still not perfect it will be hard to maintain like this, please can you try using a grid strategy like in PR #96 ? |
|
Sure i'll look into it ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Alex for the PR !
-
About the Catalonia flag, still not perfect, but much better !
-
About open-data section, I have just tested functionnlay, as the code does not change the render I accept as it is, but we still need to investigate (why bold in other langages than french)
-
In the media section, there is still quite space between the logos, but okay for now.
In general, it is easier to integrate independent changes with several small PRs (avoids leaving a lot of things pending that are valid for a blocking issue).
| url: "https://cenia.cl/" | ||
| logo: "/img/cenia.jpg" | ||
| content: "Le centre national d'intelligence artificielle chilien avec qui on travaille pour notre premier déploiement à l’étranger" | ||
| content: "Le centre national d’IA chilien, notre premier partenaire à l’international, déployant des stations à travers le Chile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| content: "Le centre national d’IA chilien, notre premier partenaire à l’international, déployant des stations à travers le Chile" | |
| content: "Le centre national d’IA chilien, notre premier partenaire à l’international, déployant des stations à travers le Chili" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved too quickly,
Can you take in the account the small typo (I have made the suggestion) ?
Also, in the media section, we still have an issue with alignment -> but I understand your are handling it in #104 :)
|
Hi indeed this pull request should be closed / discarded as it was solved in #104 as mentioned ! Sorry forgot to drop it after Mateo approved the other one, and then built above the latest version, dropping this one ! |
📰 Short Description
Refined the layout and styling for media, partners, and sponsors sections, adjusting paddings and image heights for better visual consistency. Updated _config.yml to improve / shorten partner and sponsor descriptions and fixed translation content.
Added a local image for Sécurité&Défense Magazine and updated the Catalonia flag image and its display size to fit better with other flags.
Cleaned code in open-data.html file to start correcting a bug with bolded text (still pending).
📸 Screenshots
Old



New


