Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 82.58% 82.48% -0.10%
==========================================
Files 66 66
Lines 2302 2306 +4
==========================================
+ Hits 1901 1902 +1
- Misses 401 404 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renanxcortes
approved these changes
Mar 25, 2026
Collaborator
renanxcortes
left a comment
There was a problem hiding this comment.
If this PR gets merged, then #245 gets deprecated (as it would be contemplated in this PR) and can be closed, right?
Member
Author
|
yeah, this would supercede #245 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #244
following the discussion linked above, this changes the permutation logic for the
random_labeltest in the comparative inference case. Specifically, rather than permute group membership (of all rows, including geometry), it permutes the group values, leaving geometry in place. This allows reasonable computation of all spatial indices