Config cleanups #13857
Merged
Config cleanups #13857
+88
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't help understanding much and doesn't deal with only ini (config). So inline it into `_preparse`.
Set to `None` instead of using `hasattr`.
Initially wanted to rename it to `MyArgumentParser` to make it clearer it's an `argparse.ArgumentParser`. But "My" looks funny, so change to `Pytest` similar to `PytestPluginManager`.
It only makes the code harder to understand in my opinion. Also remove the manual `setattr(option, name, value)` which are unneeded because `parse` already updates the `Namespace`.
This way it works for any error, which seems like better separation of concerns.
Let's use a single mechanism. The error is now shown in its own line but that's fine.
…elves See https://docs.python.org/3/library/argparse.html#intermixed-parsing. pytest uses the intermixed style, but implemented it manually, probably because it as only added to argparse in Python 3.7.
|
Thanks for the review @nicoddemus. I snuck in another commit, which just removes some unused global variable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small cleanups to the config/argparsing code. Nothing big but maybe making the code a bit easier to follow.
I explain each change in its own commit.