Refactor: Improve clarity of 'expected exception' error messages #13861
+13
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariomesic
force-pushed
the
fix-raises-error-messages
branch
from
de713cb to
b1fc8a1
Compare
dariomesic
force-pushed
the
fix-raises-error-messages
branch
from
0782838 to
b030c3f
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses a
TODOintesting/python/raises_group.pythat pointed out a poorly structured sentence in a test's expected error message.I traced this back to the source of the message in
src/_pytest/raises.pyand refactored it to be clearer and more direct.expected exception must be a BaseException type, not '...'Expected a BaseException type, but got '...'Tests
Because the library's error message was changed, this PR also updates all the tests in the following files that were asserting the old message:
testing/python/raises.pytesting/python/raises_group.pyThis resolves the
TODOand makes the error messages more consistent and readable.