Add notional value to opportunity models#562
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
anihamde
approved these changes
May 28, 2025
auction-server/src/opportunity/repository/add_opportunity_analytics.rs
Outdated
Show resolved
Hide resolved
| ), | ||
| skip_all | ||
| )] | ||
| async fn add_opportunity( |
Contributor
There was a problem hiding this comment.
any particular reason to move this logic out of this function?
Contributor
Author
There was a problem hiding this comment.
This trait should be isolated to work only with the analytics type. It shouldn’t be aware of the Opportunity type. The repository layer should handle any conversions between different data sources, such as analytics and Postgres. Traits in models should only accept and operate on the types they are explicitly designed to handle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add notional value to opportunities