Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
danimhr
previously approved these changes
Jun 4, 2025
| let n_opportunities_deleted = sqlx::query!( | ||
| "WITH rows_to_delete AS ( | ||
| SELECT id FROM opportunity WHERE chain_id = $1 AND creation_time < $2 LIMIT $3 | ||
| SELECT id FROM opportunity WHERE chain_id = $1 AND creation_time < $2 AND removal_time IS NOT NULL LIMIT $3 |
Contributor
There was a problem hiding this comment.
this query is not fast so we should not merge it as we have no index on removal_time (do we?)
Contributor
There was a problem hiding this comment.
Imagine there are opportunities in-memory, then the server gets restarted, now we have some opps in db without removal time which we can safely remove.
danimhr
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug whereby limo opportunities that hadn't yet been removed were liable to be deleted from the db.