Skip to content

Allow on_setattr=setters.NO_OP on frozen classes #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bysiber wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Allow on_setattr=setters.NO_OP on frozen classes #1515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/attr/_make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2014,11 +2014,13 @@ def _make_init_script(
attr_dict[a.name] = a

if a.on_setattr is not None:
if frozen is True:
if a.on_setattr is setters.NO_OP:
pass
elif frozen is True:
msg = "Frozen classes can't use on_setattr."
raise ValueError(msg)

needs_cached_setattr = True
else:
needs_cached_setattr = True
elif has_cls_on_setattr and a.on_setattr is not setters.NO_OP:
needs_cached_setattr = True

Expand Down
Loading