Update pre-commit hooks #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed mechanically using the following command: ``` pre-commit migrate-config ```
This was updated mechanically using the following command: ``` pre-commit autoupdate ```
`pyupgrade` upgrades `%` and `.format()` usage to f-strings.
Additionally, add a configuration for flake8.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
- Coverage 92.09% 91.91% -0.19%
==========================================
Files 24 24
Lines 759 742 -17
Branches 80 83 +3
==========================================
- Hits 699 682 -17
+ Misses 42 39 -3
- Partials 18 21 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kurtmckee
force-pushed
the
update-pre-commit-hooks
branch
from
e77bf1a to
dfe942b
Compare
Contributor
Author
|
Updated the pre-commit hook versions again. |
Contributor
Author
|
Happy new year, @p1c2u! I hope you're well! Would you take a look at this and the other PRs I've posted? I'd like to help ensure that the project infrastructure is up-to-date and functional, to help make the project more maintainable. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Fix deprecated pre-commit stage names.
When
pre-commit installis run, it currently throws a deprecation regarding the stage names in the config file. This is now fixed.Update the
pyupgradehook to its latest version, and update its target syntax version to Python 3.9+.Remove
flyntas a pre-commit hook.Its functionality is handled by the
pyupgradehook.Migrate from
localpre-commit hooks to standard, hosted pre-commit hooks.This change is necessary because not all git-related tooling runs pre-commit hooks with the same activated virtual environment that the Poetry dev dependencies are installed in.
Taken together, these changes bring the pre-commit hook configuration up-to-date, and make it possible to enable pre-commit.ci for the repo if you choose to do so (and I highly recommend doing so!).
Note
I've split the commits up so that it can be reviewed commit-by-commit. This isolates the manual and automatic changes so that they can be reviewed in smaller chunks.