fix: correct error message for stdout pipe check in run_process#3416
Open
nightcityblade wants to merge 2 commits intopython-trio:mainfrom
Open
fix: correct error message for stdout pipe check in run_process#3416nightcityblade wants to merge 2 commits intopython-trio:mainfrom
nightcityblade wants to merge 2 commits intopython-trio:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3416 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19424 19417 -7
Branches 1318 1318
===============================================
- Hits 19424 19417 -7
🚀 New features to boost your workflow:
|
Member
|
You forgot to update the tests mate |
Author
|
Good catch @CoolCat467! Updated the test to match the corrected error message — the stdin pipe check now expects |
mikenerone
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3409
The error message for the
stdout=subprocess.PIPEcheck inrun_processincorrectly said "stdin=subprocess.PIPE". This fixes it to say "stdout=subprocess.PIPE".This is a recreation of #3398 with the same fix plus a newsfragment.