Skip to content

gh-140704: Fix AttributeError in dataclasses on a compiled class #140705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

gh-140704: Fix AttributeError in dataclasses on a compiled class #140705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,12 +759,16 @@ def _is_type(annotation, cls, a_module, a_type, is_type_predicate):
if not module_name:
# No module name, assume the class's module did
# "from dataclasses import InitVar".
ns = sys.modules.get(cls.__module__).__dict__
module = sys.modules.get(cls.__module__)
if module:
ns = module.__dict__
else:
# Look up module_name in the class's module.
module = sys.modules.get(cls.__module__)
if module and module.__dict__.get(module_name) is a_module:
ns = sys.modules.get(a_type.__module__).__dict__
module = sys.modules.get(a_type.__module__)
if module:
ns = module.__dict__
if ns and is_type_predicate(ns.get(match.group(2)), a_module):
return True
return False
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-10-28-14-36-29.gh-issue-140704.WNP7iG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :exc:`AttributeError` in :mod:`dataclasses` when using complex
annotation with a compiled class.
Loading