gh-139588: Docs: Convert the execution model "textual" diagram to a visual diagram #140721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adorilson
requested review from
AA-Turner,
hugovk and
willingc
as code owners
StanFromIreland
changed the title
|
Note that the error has now been fixed by the other PR. |
|
gettext builder extracts the current text for translation, but the product of this pull request is not extracted for translation. (just tested) |
|
Thanks for testing, Rafael. As such, I am -0 on this, although we could keep the textual ones just for translations (instead of the graphic) using the |
|
The best would be to have this graphic but the labels translated, but I don't even know if it is possible. |
|
It also breaks on EPUB: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It prevents LaTeX PDF build error: Too deeply nested. (Regression from #139509.).
Besides, it also makes the diagram richer.
It is an alternative to #140709.
#139588: Docs: Convert the execution model "textual" diagram to a visual diagram
📚 Documentation preview 📚: https://cpython-previews--140721.org.readthedocs.build/