Skip to content

gh-140748: socket_helper.transient_internet: Unwrap UrlError.__cause__ #140749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

gh-140748: socket_helper.transient_internet: Unwrap UrlError.__cause__ #140749

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7772c
socket_helper.transient_internet: Unwrap UrlError.__cause__
encukou Oct 29, 2025
920dd4b
Typo fix
encukou Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/test/support/socket_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,10 @@ def filter_error(err):
# raise OSError('socket error', msg) from msg
elif len(a) >= 2 and isinstance(a[1], OSError):
err = a[1]
# The error can also be wrapped as __cause__:
# raise URLError(f"ftp error: {exp}") from exp
elif isinstance(err, urllib.error.URLError) and err.__cause__:
err = err.__cause__
else:
break
filter_error(err)
Expand Down
Loading