Skip to content

Conversation

@guoci
Copy link
Contributor

@guoci guoci commented Oct 29, 2025

@guoci guoci changed the title add enum.show_flag_values to enum.__all__ gh-140766: add enum.show_flag_values to enum.__all__ Oct 29, 2025
@guoci guoci marked this pull request as ready for review October 29, 2025 16:56
@guoci guoci requested a review from ethanfurman as a code owner October 29, 2025 16:56
@guoci
Copy link
Contributor Author

guoci commented Oct 29, 2025

It appears that enum.show_flag_values was intentionally not exported, but documented.

support.check__all__(self, enum, not_exported={'bin', 'show_flag_values'})

https://docs.python.org/3/library/enum.html#enum.show_flag_values

@AlexWaygood
Copy link
Member

Hmm. That seems odd to me, but I'll defer to @ethanfurman here as the enum maintainer :-)

@ethanfurman
Copy link
Member

ethanfurman commented Oct 29, 2025

Let's go ahead and put both in __all__. Please update the PR. Thanks.

Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add both bin and show_flag_values to __all__.

@bedevere-app
Copy link

bedevere-app bot commented Oct 29, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@guoci
Copy link
Contributor Author

guoci commented Oct 30, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Oct 30, 2025

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from ethanfurman October 30, 2025 14:01
@guoci
Copy link
Contributor Author

guoci commented Oct 30, 2025

bin does not have documentation

@AlexWaygood AlexWaygood changed the title gh-140766: add enum.show_flag_values to enum.__all__ gh-140766: add enum.show_flag_values and enum.bin to enum.__all__ Oct 30, 2025
…NagKF.rst

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @guoci, I'm happy to commit as-is, or you can add bin to the docs -- whatever you are comfortable with.

@guoci
Copy link
Contributor Author

guoci commented Oct 30, 2025

@ethanfurman Thanks, I will add in the docs sometime later, you can commit now.

@ethanfurman ethanfurman merged commit e4deefb into python:main Oct 30, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants