Skip to content

Make printing log lines to the terminal a little cleaner when building WASI #140772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 30, 2025
Merged

Make printing log lines to the terminal a little cleaner when building WASI #140772

merged 6 commits into from
Oct 30, 2025
+48 −29

Conversation

@brettcannon
Copy link
Member

No description provided.

@brettcannon brettcannon self-assigned this Oct 29, 2025
@brettcannon brettcannon added needs backport to 3.14 bugs and security fixes and removed awaiting core review labels Oct 29, 2025
savannahostrowski
savannahostrowski approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@savannahostrowski savannahostrowski mentioned this pull request Oct 30, 2025
Merged
@brettcannon
Copy link
Member Author

Updated for 140769 and I simplified the extra spacing logic since I actually haven't seen what terminals do with Unicode code points that are 3 or more.

@brettcannon brettcannon merged commit abd19ed into python:main Oct 30, 2025
44 checks passed
@brettcannon brettcannon deleted the wasi-pprint-logs branch October 30, 2025 17:35
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2025
@brettcannon @miss-islington
Make printing log lines to the terminal a little cleaner when buildin…
c3805cc 
…g WASI (pythonGH-140772)

(cherry picked from commit abd19ed)

Co-authored-by: Brett Cannon <brett@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 30, 2025

GH-140804 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 30, 2025
brettcannon added a commit that referenced this pull request Oct 30, 2025
@miss-islington @brettcannon
[3.14] Make printing log lines to the terminal a little cleaner when …
6c025a0 
…building WASI (GH-140772) (GH-140804)

Make printing log lines to the terminal a little cleaner when building WASI (GH-140772)
(cherry picked from commit abd19ed)

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@emmatyping emmatyping emmatyping approved these changes

@mdboom mdboom Awaiting requested review from mdboom

Assignees

@brettcannon brettcannon

Labels

OS-wasi skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brettcannon @savannahostrowski @emmatyping