-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[compression] Add Protocol _Decompressor #14885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
srittau
merged 5 commits into
python:main
from
donbarbos:add-compression-Decompressor-Protocol
Nov 14, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import io | ||
| import sys | ||
| from _typeshed import ReadableBuffer | ||
| from bz2 import BZ2Decompressor | ||
| from lzma import LZMADecompressor | ||
| from typing import cast | ||
| from typing_extensions import assert_type | ||
| from zlib import decompressobj | ||
|
|
||
| if sys.version_info >= (3, 14): | ||
| from compression._common._streams import DecompressReader, _Decompressor, _Reader | ||
| from compression.zstd import ZstdDecompressor | ||
| else: | ||
| from _compression import DecompressReader, _Decompressor, _Reader | ||
|
|
||
| ### | ||
| # Tests for DecompressReader/_Decompressor | ||
| ### | ||
|
|
||
|
|
||
| class CustomDecompressor: | ||
| def decompress(self, data: ReadableBuffer, max_length: int = -1) -> bytes: | ||
| return b"" | ||
|
|
||
| @property | ||
| def unused_data(self) -> bytes: | ||
| return b"" | ||
|
|
||
| @property | ||
| def eof(self) -> bool: | ||
| return False | ||
|
|
||
| @property | ||
| def needs_input(self) -> bool: | ||
| return False | ||
|
|
||
|
|
||
| def accept_decompressor(d: _Decompressor) -> None: | ||
| d.decompress(b"random bytes", 0) | ||
| assert_type(d.eof, bool) | ||
| assert_type(d.unused_data, bytes) | ||
|
|
||
|
|
||
| fp = cast(_Reader, io.BytesIO(b"hello world")) | ||
| DecompressReader(fp, decompressobj) | ||
| DecompressReader(fp, BZ2Decompressor) | ||
| DecompressReader(fp, LZMADecompressor) | ||
| DecompressReader(fp, CustomDecompressor) | ||
| accept_decompressor(decompressobj()) | ||
| accept_decompressor(BZ2Decompressor()) | ||
| accept_decompressor(LZMADecompressor()) | ||
| accept_decompressor(CustomDecompressor()) | ||
|
|
||
| if sys.version_info >= (3, 14): | ||
| DecompressReader(fp, ZstdDecompressor) | ||
| accept_decompressor(ZstdDecompressor()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we import this form
_compressioninstead to avoid the duplication?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, these files completely duplicate each other, since
_compression, according toVERSION, is available up to 3.13