Change submission pending_status to work like grants #4461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #4460: Instead of trying to keep pending_status in sync with status, now assume that if pending_status is None, there isn''t any pending change. While if it is set, it means the submission new pending status is the one set in the variable. Changes: - Update pending_status field to allow null=True - Remove automatic sync logic from save method - Add current_or_pending_status property - Update admin queryset to filter by null pending_status - Update reviews template to use current_or_pending_status - Update tests to reflect new behavior 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Marco Acierno <marcoacierno@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4461 +/- ##
==========================================
- Coverage 94.53% 94.52% -0.01%
==========================================
Files 352 352
Lines 10131 10127 -4
Branches 733 731 -2
==========================================
- Hits 9577 9573 -4
Misses 461 461
Partials 93 93 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4460: Instead of trying to keep pending_status in sync with status,
now assume that if pending_status is None, there isn't any pending change.
While if it is set, it means the submission new pending status is the
one set in the variable.
Changes:
Generated with Claude Code