Skip to content

[mxfp8 moe training] initialize zero tensor differently to avoid d2h sync #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

[mxfp8 moe training] initialize zero tensor differently to avoid d2h sync #3253

merged 1 commit into from
Oct 29, 2025

Conversation

@danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Oct 28, 2025 •
edited
Loading

  • I initialized a scalar "zero" tensor in a silly way which caused a d2h sync. This PR fixes it (see traces below). However, it seems to not have been impactful in practice, since e2e TPS did not change with the PR, but still worth fixing.
  • Also updates mxfp8 a2a tests to use bf16 which is what we use in practice

Before change:
Screenshot 2025-10-28 at 1 11 24 PM

After:
Screenshot 2025-10-28 at 1 11 31 PM

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3253

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 240a093 with merge base d089c6a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2025
@danielvegamyhre danielvegamyhre added mx topic: not user facing Use this tag if you don't want this PR to show up in release notes moe labels Oct 28, 2025
@danielvegamyhre danielvegamyhre merged commit d84f5b8 into main Oct 29, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@drisspg drisspg Awaiting requested review from drisspg

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. moe mx topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielvegamyhre @vkuzo