Skip to content

Remove rir extension. #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove rir extension. #4124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/scripts/unittest-linux/run_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ if [[ "${CUDA_TESTS_ONLY}" = "1" ]]; then
args+=('-k' 'cuda or gpu')
fi

(
cd build/temp*/test/cpp
ctest
)

(
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_CTC_DECODER=true
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_MOD_unidecode=true
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/unittest-linux-cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,6 @@ jobs:
python -m pip install . -v --no-build-isolation
echo "::endgroup::"

echo "::group::Run TorchAudio C tests"
(cd build/temp*/test/cpp && ./wall_collision)
echo "::endgroup::"

echo "::group::Run TorchAudio tests"
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_CTC_DECODER=true
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_MOD_unidecode=true
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/unittest-macos-cpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ jobs:
python -m pip install . -v --no-build-isolation
echo "::endgroup::"

echo "::group::Run TorchAudio C tests"
(cd build/temp*/test/cpp && ./wall_collision)
echo "::endgroup::"

echo "::group::Run TorchAudio tests"
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_CMD_APPLY_CMVN_SLIDING=true
export TORCHAUDIO_TEST_ALLOW_SKIP_IF_NO_CMD_COMPUTE_FBANK_FEATS=true
Expand Down
4 changes: 0 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ endif()


# Options
option(BUILD_RIR "Enable RIR simulation" ON)
option(BUILD_RNNT "Enable RNN transducer" ON)
option(BUILD_ALIGN "Enable forced alignment" ON)
option(BUILD_CUDA_CTC_DECODER "Build CUCTC decoder" OFF)
Expand Down Expand Up @@ -170,6 +169,3 @@ if (BUILD_CUDA_CTC_DECODER)
endif()
add_subdirectory(src/libtorchaudio/cuctc)
endif()
if (BUILD_CPP_TEST)
add_subdirectory(test/cpp)
endif()
5 changes: 0 additions & 5 deletions src/libtorchaudio/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ if(BUILD_RNNT)
endif()
endif()

if(BUILD_RIR)
list(APPEND sources rir/rir.cpp rir/ray_tracing.cpp)
list(APPEND compile_definitions INCLUDE_RIR)
endif()

if(BUILD_ALIGN)
list(
APPEND
Expand Down
1 change: 0 additions & 1 deletion src/libtorchaudio/pybind/pybind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ namespace torchaudio {
namespace {

PYBIND11_MODULE(_torchaudio, m) {
m.def("is_rir_available", &is_rir_available, "");
m.def("is_align_available", &is_align_available, "");
m.def("cuda_version", &cuda_version, "");
}
Expand Down
Loading
Loading