Skip to content

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Dec 4, 2025

Remove new passing xfails due to new Vela version is fixing some old problems.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16075

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit e1afe46 with merge base 40a18e7 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@Erik-Lundell Erik-Lundell added ciflow/trunk module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend labels Dec 4, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
@zingo
Copy link
Collaborator

zingo commented Dec 4, 2025

Hi @metascroy updating Vela sometime (almost always) cause some internal problem so this would be really good if you can check internally, you might also have internal versions strings of Vela that needs bumping at the same time somewhere that @digantdesai usually handled.

@zingo
Copy link
Collaborator

zingo commented Dec 10, 2025

This probably fixes #16173

@metascroy
Copy link
Contributor

Hi @metascroy updating Vela sometime (almost always) cause some internal problem so this would be really good if you can check internally, you might also have internal versions strings of Vela that needs bumping at the same time somewhere that @digantdesai usually handled.

Imported.

As FYI, this is my last full week in the office for the rest of the year, but both @digantdesai and @SS-JIA are back

@meta-codesync
Copy link

meta-codesync bot commented Dec 10, 2025

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D88873525.

@zingo
Copy link
Collaborator

zingo commented Dec 15, 2025

Hi @digantdesai ( and/or @SS-JIA ) is there a way to check the outcome of @metascroy test for us?

Remove now passing xfails.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I2e96ff27a2791a7ccb2ff300b67949c45b286c09
@Erik-Lundell
Copy link
Collaborator Author

Had to fix a merge conflict so needs re-import anyways

@zingo
Copy link
Collaborator

zingo commented Dec 18, 2025

@digantdesai this has been update outside of Meta and need a re-import to make CI happy :)
e.g. Meta Internal-Only Changes Check

@Erik-Lundell Erik-Lundell merged commit f3c92ae into pytorch:main Dec 26, 2025
293 of 297 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in ExecuTorch Arm Backend Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants