[slimtensor] Add SizesAndStrides and dimension utility functions for slimtensor usage #16384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slimtensor usage This diff adds the `SizesAndStrides` class for efficiently storing tensor dimension sizes and strides, along with utility functions for computing element counts and storage requirements. **Key components:** 1. **`c10/macros/Macros.h`** - Branch prediction hint macros (`SLIMTENSOR_LIKELY/UNLIKELY`) for optimizing hot paths 2. **`util/ArrayRefUtil.h`** - Re-exports ExecuTorch's `ArrayRef`, `IntArrayRef`, and `makeArrayRef`; adds `toVec()` utility for converting ArrayRef to std::vector 3. **`c10/core/SizesAndStrides.h`** - Packed container for tensor sizes and strides: - Inline storage for tensors up to 5 dimensions (no heap allocation) - Out-of-line heap storage for larger tensors - Full copy/move semantics with proper resource management - Equality operators and iterators - `std::initializer_list` overloads for convenient initialization 4. **`util/SizeUtil.h`** - Size computation utilities: - `compute_numel()` - compute total number of elements - `compute_contiguous_strides()` - compute row-major contiguous strides - `compute_storage_nbytes()` / `compute_storage_nbytes_contiguous()` - compute storage byte requirements Differential Revision: [D89749336](https://our.internmc.facebook.com/intern/diff/D89749336/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16384
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 1 Unrelated FailureAs of commit d525c32 with merge base 210047b ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adds the
SizesAndStridesclass for efficiently storing tensor dimension sizes and strides, along with utility functions for computing element counts and storage requirements.Key components:
c10/macros/Macros.h- Branch prediction hint macros (SLIMTENSOR_LIKELY/UNLIKELY) for optimizing hot pathsutil/ArrayRefUtil.h- Re-exports ExecuTorch'sArrayRef,IntArrayRef, andmakeArrayRef; addstoVec()utility for converting ArrayRef to std::vectorc10/core/SizesAndStrides.h- Packed container for tensor sizes and strides:std::initializer_listoverloads for convenient initializationutil/SizeUtil.h- Size computation utilities:compute_numel()- compute total number of elementscompute_contiguous_strides()- compute row-major contiguous stridescompute_storage_nbytes()/compute_storage_nbytes_contiguous()- compute storage byte requirementsDifferential Revision: D89749336