Cortex_M backend: Improve PatternMatcher algorithm#17776
Merged
AdrianLundell merged 3 commits intopytorch:mainfrom Mar 3, 2026
Merged
Cortex_M backend: Improve PatternMatcher algorithm#17776AdrianLundell merged 3 commits intopytorch:mainfrom
AdrianLundell merged 3 commits intopytorch:mainfrom
Conversation
The previous algorithm failed for cases where a pattern matched outside of the nodes given by the node iterator. Update to a queue based algorithm to keep the function as a generator and add testing of this case. Additionally do not quantize operators with very large inputs and remove unused filter_fn for filtering out nodes. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: Idbbd6e0261d9e31f3b64ee1c229cc626c42ad435
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17776
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Unrelated FailuresAs of commit c83699d with merge base 0d010de ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rascani
approved these changes
Mar 3, 2026
psiddh
reviewed
Mar 3, 2026
psiddh
approved these changes
Mar 3, 2026
Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I6f02769379a5e58471994a7bd2f79084c89d0881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous algorithm failed for cases where a pattern matched outside of the nodes given by the node iterator.
Update to a queue based algorithm to keep the function as a generator and add testing of this case.
Additionally do not quantize operators with very large inputs and remove unused filter_fn for filtering out nodes.
cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell