Skip to content

NXP backend: Add option to dump kernel selection for Neutron converter#17778

Merged
roman-janik-nxp merged 2 commits intopytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter
Mar 3, 2026
Merged

NXP backend: Add option to dump kernel selection for Neutron converter#17778
roman-janik-nxp merged 2 commits intopytorch:mainfrom
nxp-upstream:feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter

Conversation

@roman-janik-nxp
Copy link
Collaborator

@roman-janik-nxp roman-janik-nxp commented Mar 2, 2026

Summary

Adds option to dump kernel selection for Neutron converter. This kernel selection file can be used for selective build of Neutron Firmware, allowing to decrease app size on MCUs with limited RAM. Docs provided.

Test plan

Unit-tests provided.

cc @robert-kalmar @JakeStevens @digantdesai

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17778

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit eacd364 with merge base 9dc7ab0 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2026
@roman-janik-nxp roman-janik-nxp changed the title NXP backend: Add option to dump kernel selection for neutron converter NXP backend: Add option to dump kernel selection for Neutron converter Mar 2, 2026
@roman-janik-nxp roman-janik-nxp added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Mar 2, 2026
@roman-janik-nxp roman-janik-nxp requested review from MartinPavella, jirioc and robert-kalmar and removed request for mergennachin and robert-kalmar March 2, 2026 11:37
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter branch from 9ce2305 to 89aa715 Compare March 2, 2026 12:54
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter branch from 89aa715 to bd027e0 Compare March 2, 2026 14:16
@@ -1,3 +1,3 @@
--index-url https://eiq.nxp.com/repository
eiq-neutron-sdk==2.2.2
eiq-neutron-sdk==3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the kernel selection work with 2.2.2 or must it be upgraded to 3.0.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's present in 3.0.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JakeStevens are updates of the eiq_neutron_sdk laborious in your setup?
The reason I am asking is with eiq_neutron_sdk, we can provide updates/fixes to neutron more quickly, as the eiq_neutron_sdk is planned to be released on monthly cadence.

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter branch from bd027e0 to f334156 Compare March 3, 2026 10:56
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter branch from f334156 to dbd7ae8 Compare March 3, 2026 13:28
Copy link
Collaborator

@MartinPavella MartinPavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing header, LGTM

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter branch from dbd7ae8 to 596e74b Compare March 3, 2026 14:27
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter branch from 596e74b to eacd364 Compare March 3, 2026 14:29
@roman-janik-nxp
Copy link
Collaborator Author

The failing checks seem unrelated and the internal build passed. Merging.

@roman-janik-nxp roman-janik-nxp merged commit 8080286 into pytorch:main Mar 3, 2026
153 of 157 checks passed
@roman-janik-nxp roman-janik-nxp deleted the feature/nxg11066/EIEX-697-Add-option-to-dump-kernel-selection-for-Neutron-Converter branch March 3, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants