Skip to content

Arm backend: Rewrite le/lt to ge/gt and simplify visitors#17783

Open
Sebastian-Larsson wants to merge 1 commit intopytorch:mainfrom
Sebastian-Larsson:rewrite_lelt_to_gegt
Open

Arm backend: Rewrite le/lt to ge/gt and simplify visitors#17783
Sebastian-Larsson wants to merge 1 commit intopytorch:mainfrom
Sebastian-Larsson:rewrite_lelt_to_gegt

Conversation

@Sebastian-Larsson
Copy link
Collaborator

@Sebastian-Larsson Sebastian-Larsson commented Mar 2, 2026

Add a pass that rewrites le/lt to ge/gt with swapped inputs. Move eq/ge/gt to SimpleNodeVisitor and drop comparison visitor. Create test for rewrite_le_lt_to_ge_gt_pass.

cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell

Add a pass that rewrites le/lt to ge/gt with swapped inputs.
Move eq/ge/gt to SimpleNodeVisitor and drop comparison visitor.
Create test for rewrite_le_lt_to_ge_gt_pass.

Change-Id: I6c79fb009ff47a1195ae47f417c2e66fa16147bb
Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
@Sebastian-Larsson Sebastian-Larsson added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Mar 2, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17783

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 2 Pending

As of commit 3cbad61 with merge base dae7a02 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2026
@zingo
Copy link
Collaborator

zingo commented Mar 2, 2026

@SS-JIA Hi this add/removes some file and might need a buck2 review

@SS-JIA
Copy link
Contributor

SS-JIA commented Mar 3, 2026

@zingo there were some issues importing this PR yesterday - trying again now

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Mar 3, 2026

@SS-JIA has imported this pull request. If you are a Meta employee, you can view this in D94910952.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants