Arm backend: Rewrite le/lt to ge/gt and simplify visitors#17783
Open
Sebastian-Larsson wants to merge 1 commit intopytorch:mainfrom
Open
Arm backend: Rewrite le/lt to ge/gt and simplify visitors#17783Sebastian-Larsson wants to merge 1 commit intopytorch:mainfrom
Sebastian-Larsson wants to merge 1 commit intopytorch:mainfrom
Conversation
Add a pass that rewrites le/lt to ge/gt with swapped inputs. Move eq/ge/gt to SimpleNodeVisitor and drop comparison visitor. Create test for rewrite_le_lt_to_ge_gt_pass. Change-Id: I6c79fb009ff47a1195ae47f417c2e66fa16147bb Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17783
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled Job, 2 PendingAs of commit 3cbad61 with merge base dae7a02 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
@SS-JIA Hi this add/removes some file and might need a buck2 review |
Contributor
|
@zingo there were some issues importing this PR yesterday - trying again now |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pass that rewrites le/lt to ge/gt with swapped inputs. Move eq/ge/gt to SimpleNodeVisitor and drop comparison visitor. Create test for rewrite_le_lt_to_ge_gt_pass.
cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell