-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Invert CV-CUDA Backend #9290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Invert CV-CUDA Backend #9290
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9290
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New FailuresAs of commit 637b4c4 with merge base aa35ca1 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
d1a4eff to
437ea99
Compare
zy1git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment as the first round review. Feel free to let me know your thoughts.
| # we save these here, since they are static and small in size | ||
| if "base" not in _invert_cvcuda_tensors: | ||
| _invert_cvcuda_tensors["base"] = cvcuda.as_tensor( | ||
| torch.tensor([0.0, 0.0, 0.0], dtype=torch.float32, device="cuda").reshape(1, 1, 1, 3).contiguous(), "NHWC" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base and scale tensors are hardcoded for 3 channels (RGB). The current CV-CUDA tests only use the default color_space="RGB", so they wouldn't catch issues with grayscale (1 channel). Is this a problem?
Summary
Implements the CV-CUDA backend kernel for
invertTesting
python3 -m pytest test/test_transforms_v2.py::TestInvert