Adjust value assignment logic in event.py#311
Open
M123-dev wants to merge 3 commits intopytr-org:masterfrom
Open
Adjust value assignment logic in event.py#311M123-dev wants to merge 3 commits intopytr-org:masterfrom
M123-dev wants to merge 3 commits intopytr-org:masterfrom
Conversation
Modified value assignment to allow None when amount is zero.
Collaborator
|
Thanks for the contribution. I enabled the checks and it shows that there is a formatting error. Can you please take a look and update your change. The parsing tests seem to work fine, though, so I think your change should be integrated when everything is green. |
Author
|
Heyy @RealCLanger thanks for the review. I have updated the PR so that the linter should be satisfied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #224
Somehow I (and some others) got a "Verkaufsorder"/Sale with the attribute
Which caused an error because the parser explicitly checked for
value != 0.0.This pull request removes the explicit check for zero values when parsing the
amount.valuefield, so a value of0.0will now be considered valid instead of being replaced withNone.That being said I am not sure why there was this explicit check, if it has a specific reason this PR should probably not be merged as it. I am using my fork right now, and it works for me 👍🏼