fix(client): prevent native crash in RaycastCamera#216
Open
NebelRebell wants to merge 1 commit intoqbcore-framework:mainfrom
Open
fix(client): prevent native crash in RaycastCamera#216NebelRebell wants to merge 1 commit intoqbcore-framework:mainfrom
NebelRebell wants to merge 1 commit intoqbcore-framework:mainfrom
Conversation
Adds proper entity validation to prevent native crashes caused by invalid entity handles. - Validates entityHit against 0 and -1 - Uses DoesEntityExist before native calls - Fixes parameter order in HasEntityClearLosToEntity - Adds safe fallback for entityType == 0 Tested and verified on FiveM game build 2944.
|
Are we going to have to start reviewing AI PRs now? This is a bit of a mess. The comment choices need a lot of work. I won't comment on the AI code because I'm not going to read it. |
Qwerty1Verified
requested changes
Mar 21, 2026
Member
Qwerty1Verified
left a comment
There was a problem hiding this comment.
This doesn't fit the coding style guide, and similar to what MadCap said, I'd rather us not have to review AI code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds proper entity validation to prevent native crashes caused by invalid entity handles.
Tested and verified on FiveM game build 2944.
This PR fixes native crashes triggered by invalid entity handles returned from GetShapeTestResult, which could lead to:
SCRIPT ERROR: Error executing native 0x8acd366038d14505
SCRIPT ERROR: Error executing native 0xfcdff7b72d23a1ac
The issue was caused by Lua treating 0 as truthy, allowing invalid entity handles to reach native calls.