Correct Qdrant/bge-base-en-v1.5-onnx-Q model name#593
Correct Qdrant/bge-base-en-v1.5-onnx-Q model name#593Harnas wants to merge 1 commit intoqdrant:mainfrom
Conversation
Wrong name causes HTTP redirection, what may be wrongly handled by proxies.
📝 WalkthroughWalkthroughUpdated the HuggingFace model source identifier for the BAAI/bge-base-en-v1.5 ONNX embedding model variant in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JiwaniZakir
left a comment
There was a problem hiding this comment.
The fix in fastembed/text/onnx_embedding.py corrects the HuggingFace model identifier from qdrant/bge-base-en-v1.5-onnx-q to Qdrant/bge-base-en-v1.5-onnx-Q, matching the exact casing on the HuggingFace Hub. While HuggingFace namespace lookups are typically case-insensitive, the model filename suffix Q (indicating quantization) may be case-sensitive in some download or caching contexts, so this is a worthwhile correction.
It's worth verifying whether there are any existing users or cached configurations relying on the lowercase qdrant/bge-base-en-v1.5-onnx-q string — for instance, if the model_name field is used as a cache key or serialized in user-facing config files, the case change could cause a cache miss or a mismatch when loading previously saved embeddings. A brief note in the changelog or a backward-compatibility alias might be warranted.
Also worth checking: are there other model entries in onnx_embedding.py or sibling files (e.g. fastembed/image/) that have the same inconsistency between their declared hf name and the actual Hub identifier? A quick audit of all ModelSource(hf=...) values against their canonical Hub paths would prevent similar silent failures.
Wrong name causes HTTP redirection, what may be wrongly handled by proxies.
All Submissions: