Improved performance of ps_agent_flexible for large number of percepts#1
Open
jwallnoefer wants to merge 1 commit intoqic-ibk:masterfrom
Open
Improved performance of ps_agent_flexible for large number of percepts#1jwallnoefer wants to merge 1 commit intoqic-ibk:masterfrom
jwallnoefer wants to merge 1 commit intoqic-ibk:masterfrom
Conversation
Especially important when using python2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially important when using python2.
Explanation: The dictionary
keys()method returns a list in python2, while in python3 it returns a dict_keys object. Needlessly building a list slows down the code significantly even for a moderate amount of percepts. (My code took about 10x longer to run on the cluster where only python2 is available.)There is also a tiny speed-up for python3.