Skip to content

Conversation

@HackingFrogWithSunglasses
Copy link
Contributor

As per #1217 - here is the x86_64 Qdb support

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • [*] This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • [*] The new code conforms to Qiling Framework naming convention.
  • [*] The imports are arranged properly.
  • [*] Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • [*] Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • [*] Changelog has been updated in my PR.

Target branch?

  • [*] The target branch is dev branch.

One last thing


@elicn
Copy link
Member

elicn commented Aug 31, 2022

@ucgJhe - you are welcome to comment.

@ucgJhe
Copy link
Collaborator

ucgJhe commented Sep 7, 2022

@HackingFrogWithSunglasses Thanks for your contribution, add some tests for Qdb will make this PR even better.

@HackingFrogWithSunglasses
Copy link
Contributor Author

Hey,

Thanks for your positive feedback, I really appreciate it.

Unfortunately, I simply don't have the time to refine this PR to the way in which you may like. I am also not the best placed person to do this, as I am not a developer. I simply decided to upstream these changes because I felt like other might want them.

You are absolutely welcome to adapt the PR and use it, or not. I am fine with either way :)

@xwings
Copy link
Member

xwings commented Sep 23, 2022

Hey, welcome to Qiling.

I will merge as per advice from @ucgJhe, thank you!

@kabeor kabeor merged commit bd2074b into qilingframework:dev Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants