Skip to content

Enable averaging PUB params #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2025
Merged

Enable averaging PUB params #1602

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
150b531
Enable averging PUB params
LiranShirizly Nov 3, 2025
4521f9f
fix typo
LiranShirizly Nov 3, 2025
c121f78
fix typo
LiranShirizly Nov 3, 2025
d6b107f
allow average only of meas_level=2 and update shots
LiranShirizly Nov 3, 2025
1e17b1a
black
LiranShirizly Nov 3, 2025
abaad9f
fix logic
LiranShirizly Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions qiskit_experiments/framework/experiment_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1099,11 +1099,21 @@ def _add_result_data(
if testres.data:
joined_data = testres.join_data()
outer_shape = testres.data.shape
if outer_shape:
average_params = (
result[i]
.metadata.get("circuit_metadata", {})
.get("average_params", False)
)
if (
outer_shape
and not average_params
and not isinstance(joined_data, BitArray)
):
Copy link
Collaborator

@wshanks wshanks Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic needs to be outer_shape and (not average_params or not isinstance(joined_data, BitArray)) or outer_shape and not (average_params and isinstance(joined_data, BitArray))?

Copy link
Contributor Author

@LiranShirizly LiranShirizly Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right. thanks!

raise QiskitError(
f"Outer PUB dimensions {outer_shape} found in result. "
"Only unparameterized PUBs are currently supported by "
"qiskit-experiments."
"qiskit-experiments unless the circuit metadata "
"indicates to average them and it used meas_level=2."
)
else:
joined_data = None
Expand All @@ -1124,7 +1134,7 @@ def _add_result_data(
data["counts"] = testres.join_data(testres.data.keys()).get_counts()
data["memory"] = testres.join_data(testres.data.keys()).get_bitstrings()
# number of shots
data["shots"] = joined_data.num_shots
data["shots"] = len(data["memory"])
elif isinstance(joined_data, np.ndarray):
data["meas_level"] = 1
if joined_data.ndim == 1:
Expand Down
6 changes: 6 additions & 0 deletions releasenotes/notes/average-pub-params-f24fd73f817051ac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---

features:
- |
Enable averaging PUB parameters in :class:`~.ExperimentData` when
the circuit metadata contain "average_params".
Loading