Skip to content

qt-python: Show error popup when pip install fails #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

qt-python: Show error popup when pip install fails #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions qt-python/src/installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,29 +182,32 @@ async function tryInstallPySide(
runner.onStdout(logIndented);
runner.onStderr(logIndented);

if (source.source === 'oss') {
await runner.run('pip install PySide6', { useVenv: true });
} else if (source.source === 'local' && source.localPath) {
await runner.run('pip install -r requirements.txt', {
useVenv: true,
cwd: source.localPath
});
} else {
return;
}
try {
if (source.source === 'oss') {
await runner.run('pip install PySide6', { useVenv: true });
} else if (source.source === 'local' && source.localPath) {
await runner.run('pip install -r requirements.txt', {
useVenv: true,
cwd: source.localPath
});
} else {
return;
}

await projectManager.refreshEnv(folder);
const pyside = await env.readPySide6PackageInfo(logIndented);
if (!pyside) {
throw new Error('Cannot read PySide6 package information');
}

const pyside = await env.readPySide6PackageInfo(logIndented);
if (pyside) {
await projectManager.refreshEnv(folder);
void vscode.window.showInformationMessage(
texts.install.popup.installed(
folder.name,
pyside.version,
env.venvName ?? ''
)
);
} else {
} catch (e) {
void vscode.window.showWarningMessage(
texts.install.popup.installFailed(folder.name) + ` (${linkShowLogs})`
);
Expand Down
Loading