Skip to content

Comments

Fix resize on another screen, closes #14, closes #10#15

Open
somenewacc wants to merge 6 commits intoqtdevs:masterfrom
somenewacc:patch-1
Open

Fix resize on another screen, closes #14, closes #10#15
somenewacc wants to merge 6 commits intoqtdevs:masterfrom
somenewacc:patch-1

Conversation

@somenewacc
Copy link

@somenewacc somenewacc commented Apr 20, 2021 •
edited
Loading

It only fixes the resize problem, but actually I see some other issues.

@somenewacc
Copy link
Author

somenewacc commented Apr 20, 2021 •
edited
Loading

I see some issues now:

When I move window to second screen with 150% or 175% scale, I can't drag with titlebar on second screen.
But everything works with 100% and 125% scale.

When window is splitted by 2 screens part on screen with 150% works fine but part on screen with 100% resizeable on all frame (will take a look if it can be fixed):
image
image

Known bug after move window to different screen:
image
Any fixes/workarounds?

@somenewacc
Copy link
Author

somenewacc commented Apr 21, 2021

I added commit to fix issue 3 in my list.
This commit also probably closes #10 and #7.
c723c1c

@somenewacc somenewacc changed the title Fix resize on another screen, closes #14 Fix resize on another screen, closes #14, closes #10 Apr 21, 2021
@somenewacc
Copy link
Author

somenewacc commented Jun 27, 2021

I rewrite code using map from global in HitTest, it works really fine now!
But there are another problems:

  1. Part of window on another screen while maximized:
    image

  2. If I minimize window on second screen from maximized state, graphics hang after I try to show it:
    image

@somenewacc
Fixes:
6497a9f 
- fix window size when maximized (remove 1 pixel from top and left)
- g rect with scaleFactor
- add case for WM_MOVE to update window on move
- remove NativeWindowHelperPrivate::availableGeometry()
(Fix for blank window now it's returns only
window->screen()->availableGeometry())
- hitTest: scaledTitleBarHeight now doesn't use scaleFactor
- add excludeItems.contains(child->parentWidget()) check in hitTest
(fixes problem with buttons in toolbar)
@somenewacc
Copy link
Author

somenewacc commented Feb 28, 2022 •
edited
Loading

With latest commit I fixed all issues that I know so far. Now it's pretty usable (atleast for my applications).
I made it a while ago but decided to commit changes now. Some changes I don't really remember now (such as g with scale or WM_MOVE case in nativeEventFilter) but it's works fine for me on any setup I tested.
Feel free to contact me if you see any issues.

UPD:
Seems like g.set*(g.*() * d->scaleFactor) makes window size incorrect on screen with scale. Removed it.

@somenewacc
Fix:
8346569 
- remove g.set*(g.*() * d->scaleFactor) for window on screen with scale
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@somenewacc