minkipc: Add libraries and applications for security feature support #1094
Conversation
jiaxli-QC
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
Also please drop 'meta-qcom: security: from the commit subjects, use 'Add recipe <>' with short meaning to the recipe. |
|
And split the commits that are including the packages in the packagegroup. |
I don't think we need packagegroup at all. In the end, we only need the |
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Please go through all review comments and implement all of them or at least provide some response to the comments that think are not correct or not applicable.
recipes-security/minkipc/minkipc/0001-minkipc-compilation-Fix-compilation-issue.patch
Outdated
Show resolved
Hide resolved
dynamic-layers/openembedded-layer/recipes-security/minkipc/minkipc_git.bb
Show resolved
Hide resolved
|
Hi @lumag . Currently, minkidlc has only released an x86 version binary for users, and all use cases are based on x86 hosts. More validation is needed on different hosts before expanding minkidlc support. |
OE provides support for building Rust binaries. minkidlc is provided in the source form. It has 0 tests to check for regressions, but that's a different topic. So, no. I don't think we should accept downloading a binary to be executed on the build host. |
jiaxli-QC
force-pushed
the
master
branch
2 times, most recently
from
2f341ae to
4893e2c
Compare
Hi @lumag , Do you mean we should raised the minkidlc compilation change in OE-core repo? I tried to compile the minkidlc in meta-qcom, but encountered some issues. |
Please add the source code for the recipe that you are trying to build. I can't comment the failure without looking at your recipe. |
Here is the bb file that has been created for minkidlc compilation. SUMMARY = "Mink IDL compiler (prebuilt binary)"
DESCRIPTION = " \
Mink IDL is used to describe programming interfaces that can be used to communicate across security domain boundaries. \
Once an interface is described in an IDL source file, the Mink IDL compiler can generate target language header files. \
"
LICENSE = "BSD-3-Clause"
LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=acff25b0ff46523fa016b260dbf64945"
SRC_URI = "git://github.com/quic/mink-idl-compiler.git;branch=main;protocol=https"
SRCREV = "1a52cd017ae21750c23e01851fdffd143f9c85d0"
inherit cargo native
DEPENDS += "rust-native cargo-native"
do_install() {
install -d ${D}${bindir}
install -m 0755 ${S}/target/debug/idlc ${D}${bindir}/minkidlc
}
FILES:${PN} += "${bindir}/minkidlc" |
|
Use |
I updated the bb file based on the comments, but the same issue occurred during compilation. error: no matching package named Here is the patch @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=acff25b0ff46523fa016b260dbf64945"
SRC_URI = "git://github.com/quic/mink-idl-compiler.git;branch=main;protocol=https"
SRCREV = "1a52cd017ae21750c23e01851fdffd143f9c85d0"
-inherit cargo native
+cargo rust cargo-update-recipe-crates
+BBCLASSEXTEND += "native"
-DEPENDS += "rust-native cargo-native" |
|
The update masks arm32 builds by using +# The module is only promised to support ARMv8 machines
+COMPATIBLE_MACHINE = "^$"
+COMPATIBLE_MACHINE:aarch64 = "(.*)" |
Test run workflowTest jobs for commit 57a216e
|
Test run workflowTest jobs for commit 57a216e
|
dynamic-layers/openembedded-layer/recipes-security/minkipc/minkipc_git.bb
Outdated
Show resolved
Hide resolved
Minkipc is designed to facilitate secure communication between different domains. Add the minkipc component to dynamic-layer because it depends on the qcbor library from the meta-openembedded dynamic layer. Signed-off-by: Jiaxing Li <jiaxing.li@oss.qualcomm.com>
|
Updated the comment at minkipc_git.bb, line 36 for 869fcee |
dynamic-layers/openembedded-layer/recipes-security/minkipc/minkipc_git.bb
Show resolved
Hide resolved
jiaxli-QC
requested review from
lumag,
ricardosalveti,
vkraleti and
vksharma-oss
Hi @lumag , @ricardosalveti , @vkraleti , this was generated by |
Should be fixed with qualcomm-linux/meta-qcom-distro#115 |
|
@jiaxli-QC please stop randomly requesting reviews. The PR could have been merged if you didn't retrigger (unnecessarily) review requests. |
|
Also please don't post useless blobs from Copilot, the posted "solution" is pretty useless here. |
Test run workflowTest jobs for commit 869fcee
|
Test run workflowTest jobs for commit 869fcee
|
ricardosalveti
merged commit 45379e3
into
qualcomm-linux:master
- Define packagegroup-qcom-security to include minkipc-qteesupplicant, enabling communication between QTEE (QCOM Trusted Execution Environment) and REE (Rich Execution Environment). This package is compatible only with aarch64 (ARMv8). - Add packagegroup-qcom-security to qcom-console-image.bb file. Reference: qualcomm-linux/meta-qcom#1094
9 participants
Add the minkipc component to dynamic-layer because it depends on the qcbor library from the meta-openembedded dynamic layer.