Skip to content

Conversation

@quic-vkatoch
Copy link

@quic-vkatoch quic-vkatoch commented Dec 15, 2025

Enable dynamic DSP path resolution, fix envlistlen handling, and update build dependencies.

  • Support dynamic DSP path resolution via a conf directory for flexible DSP library location management.
  • Prevent envlistlen from being overwritten when fetching non-DSP environment paths to avoid undefined behavior.
  • Update build steps to:
    • include apt-get update
    • install libyaml-dev
    • rename the step to "Install autotools and dependencies".

LICENSE = "BSD-3-Clause"
LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=b67986b6880754696d418dbaa2cf51d1"

DEPENDS += "pkgconfig-native libyaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for += when DEPENDS is above any inherit lines.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Copy link
Contributor

@koenkooi koenkooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the other commits, the commit message doesn't follow the OE (and meta-qcom) commit policy. It should look like this:

fastrpc: add patch for dynamic DSP path resolution

Enable dynamic path resolution....

Enable dynamic DSP path resolution, fix envlistlen handling, and update
build dependencies.

- Support dynamic DSP path resolution via a conf directory for flexible
  DSP library location management.
- Prevent envlistlen from being overwritten when fetching non-DSP
  environment paths to avoid undefined behavior.
- Update build steps to:
  - include apt-get update
  - install libyaml-dev
  - rename the step to "Install autotools and dependencies".

Signed-off-by: Vinayak Katoch <vkatoch@qti.qualcomm.com>
@quic-vkatoch
Copy link
Author

Apart from the other commits, the commit message doesn't follow the OE (and meta-qcom) commit policy. It should look like this:

fastrpc: add patch for dynamic DSP path resolution
Enable dynamic path resolution....

Ack, updated.

@quic-vkatoch quic-vkatoch changed the title Enable dynamic DSP path resolution, fix envlistlen, update build deps fastrpc: add patch for dynamic DSP path resolution Dec 16, 2025
@lumag
Copy link
Contributor

lumag commented Dec 16, 2025

What is so urgent that we can't wait for the release?

@quic-vkatoch
Copy link
Author

What is so urgent that we can't wait for the release?

FastCV skels added as part of PR "qcom-fastcv-binaries: FastCV DSP Support Enhancements by quic-ptak · Pull Request #1162 · qualcomm-…" cannot be successfully loaded without this PR. Although a temporary workaround using symlinks from board-specific paths to /usr/lib/dsp/cdsp is available, clients are unwilling to maintain this solution for an extended period. Since the main PR is still pending from approval and its release takes time, we are planning to provide the needed functionality to clients with this patch.

@quic-vkatoch quic-vkatoch marked this pull request as ready for review December 17, 2025 09:32
@lumag
Copy link
Contributor

lumag commented Dec 17, 2025

What is so urgent that we can't wait for the release?

FastCV skels [...] cannot be successfully loaded without this PR. Although a temporary workaround using symlinks from board-specific paths to /usr/lib/dsp/cdsp is available, clients are unwilling to maintain this solution for an extended period. Since the main PR is still pending from approval and its release takes time, we are planning to provide the needed functionality to clients with this patch.

I'd really like to hear a word from the FastRPC team here. What is their plan for the release?

@Chennak-quic
Copy link

What is so urgent that we can't wait for the release?

FastCV skels [...] cannot be successfully loaded without this PR. Although a temporary workaround using symlinks from board-specific paths to /usr/lib/dsp/cdsp is available, clients are unwilling to maintain this solution for an extended period. Since the main PR is still pending from approval and its release takes time, we are planning to provide the needed functionality to clients with this patch.

I'd really like to hear a word from the FastRPC team here. What is their plan for the release?

@lumag , we’re awaiting your approval for qualcomm/fastrpc#234 . Once approved, we will complete our release testing and deliver the change within two days.

@lumag
Copy link
Contributor

lumag commented Dec 30, 2025

Closing, obsoleted by #1334

@lumag lumag closed this Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants