-
Notifications
You must be signed in to change notification settings - Fork 178
fastrpc: add patch for dynamic DSP path resolution #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fastrpc: add patch for dynamic DSP path resolution #1305
Conversation
5870c36 to
6b19aca
Compare
| LICENSE = "BSD-3-Clause" | ||
| LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=b67986b6880754696d418dbaa2cf51d1" | ||
|
|
||
| DEPENDS += "pkgconfig-native libyaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for += when DEPENDS is above any inherit lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
koenkooi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the other commits, the commit message doesn't follow the OE (and meta-qcom) commit policy. It should look like this:
fastrpc: add patch for dynamic DSP path resolution
Enable dynamic path resolution....
Enable dynamic DSP path resolution, fix envlistlen handling, and update build dependencies. - Support dynamic DSP path resolution via a conf directory for flexible DSP library location management. - Prevent envlistlen from being overwritten when fetching non-DSP environment paths to avoid undefined behavior. - Update build steps to: - include apt-get update - install libyaml-dev - rename the step to "Install autotools and dependencies". Signed-off-by: Vinayak Katoch <vkatoch@qti.qualcomm.com>
6b19aca to
b9b33c3
Compare
Ack, updated. |
|
What is so urgent that we can't wait for the release? |
FastCV skels added as part of PR "qcom-fastcv-binaries: FastCV DSP Support Enhancements by quic-ptak · Pull Request #1162 · qualcomm-…" cannot be successfully loaded without this PR. Although a temporary workaround using symlinks from board-specific paths to /usr/lib/dsp/cdsp is available, clients are unwilling to maintain this solution for an extended period. Since the main PR is still pending from approval and its release takes time, we are planning to provide the needed functionality to clients with this patch. |
I'd really like to hear a word from the FastRPC team here. What is their plan for the release? |
@lumag , we’re awaiting your approval for qualcomm/fastrpc#234 . Once approved, we will complete our release testing and deliver the change within two days. |
|
Closing, obsoleted by #1334 |
Enable dynamic DSP path resolution, fix envlistlen handling, and update build dependencies.