Skip to content

Conversation

@codeshravan
Copy link

Include *.rootfs.ostreecommit.tar.xz files in the artifact staging and upload process for nightly builds. This ensures OSTree commit archives are preserved alongside other build artifacts.

The find command pattern is added to the symbolic link copy operation, which will gracefully handle cases where ostreecommit files are not present for certain machine configurations.

Files matching this pattern will be:

  • Copied to the uploads directory
  • Uploaded as private artifacts
  • Published to the S3 bucket for build artifact storage

@lumag
Copy link
Contributor

lumag commented Jan 19, 2026

Please use git log to check the pattern that other commits are using (and this one doesn't).
Then please update commit message. Start with the description of the problem you are trying to solve. Don't describe patch contents nor the changes (they are quite obvious from the patch itself).

@codeshravan
Copy link
Author

@lumag below is fine?

nightly builds: retain OSTree commit artifacts

Nightly builds currently discard OSTree commit archives, making it
difficult to inspect, debug, or reproduce images generated from those
builds. Ensure OSTree commit outputs are preserved and available
alongside other nightly build artifacts, while gracefully handling
configurations that do not produce OSTree commits.

Signed-off-by: Shravan Kumar shrkum@qti.qualcomm.com

@quaresmajose
Copy link
Contributor

quaresmajose commented Jan 20, 2026

The change is on the compile actions and they will deployed whenever the file *.rootfs.ostreecommit.tar.xz exists and not only on the nightly builds. it's best to remove the nightly builds mentions from the commit subject and message.

ci: actions/compile: retain OSTree commit artifacts describes the commit better in my opinion.

@codeshravan codeshravan changed the title Add ostreecommit artifacts to nightly build retention ci: actions/compile: : retain OSTree commit artifacts Jan 20, 2026
Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/were not preserved/are not preserved/.
LGTM otherwise.

OSTree commit archives generated during builds are not being preserved,
making it difficult to inspect, debug, or reuse build outputs when such
artifacts are produced. Retain OSTree commit artifacts whenever they are
available, while remaining compatible with configurations that do not
generate them.

Signed-off-by: Shravan Kumar <shrkum@qti.qualcomm.com>
@codeshravan
Copy link
Author

s/were not preserved/are not preserved/. LGTM otherwise.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants