recipes-support: Add time-services recipe #1425
Open
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jairaj-quic
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
Jairaj-quic
force-pushed
the
time-services-feature
branch
from
9e0a7db to
5a42e26
Compare
Add time-services daemon recipe for syncing time from modem to APPS. - Add time-services_0.1.0.bb recipe using upstream v0.1.0 release - Add systemd service file with RTC read-only device access - Service depends on QMI framework for modem communication Signed-off-by: Jairaj Solanki <jsolanki@qti.qualcomm.com>
Jairaj-quic
force-pushed
the
time-services-feature
branch
from
5a42e26 to
f59d58e
Compare
anujm1
reviewed
Jan 22, 2026
|
|
||
| inherit autotools pkgconfig systemd | ||
|
|
||
| EXTRA_OECONF = "--with-qmif-prefix=${STAGING_DIR_TARGET}${prefix}" |
Contributor
There was a problem hiding this comment.
The code seems to be assuming the libs will always be in $prefix/lib and hardcodes path to headers. qmi-framework doesn't provide a .pc file?
lumag
requested changes
Jan 22, 2026
| LIC_FILES_CHKSUM = "file://LICENSE;md5=65b8cd575e75211d9d4ca8603167da1c" | ||
|
|
||
| SRC_URI = "git://github.com/quic/time-services.git;branch=main;protocol=https;tag=v${PV} \ | ||
| file://time-daemon.service \ |
Contributor
There was a problem hiding this comment.
The service file should be a part of the source repo, please move it there.
|
|
||
| do_install:append() { | ||
| install -d ${D}${systemd_system_unitdir} | ||
| install -m 0644 ${UNPACKDIR}/time-daemon.service ${D}${systemd_system_unitdir}/ |
Contributor
There was a problem hiding this comment.
This also should be done by the upstream too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add time-services daemon recipe for syncing time from modem to APPS.