Fix: AudioPlayback no longer requires network when clips exist #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves qualcomm-linux#229 Problem: AudioPlayback test was forcing network connections even when audio files were already present locally, causing tests to fail in offline environments. Solution: - Add --enable-network-download flag (opt-in, default: disabled) - Add audio_check_clips_available() to check files before network ops - Implement smart network gating: only connect if files missing AND flag enabled - Auto-enable network download when WiFi credentials provided via CLI Signed-off-by: Teja Swaroop Moida <tmoida@qti.qualcomm.com>
smuppand
requested changes
Dec 19, 2025
| - $REPO_PATH/Runner/utils/send-to-lava.sh AudioPlayback.res || true | ||
| - | | ||
| if [ "${ENABLE_NETWORK_DOWNLOAD}" = "true" ]; then | ||
| ./run.sh --backend "${AUDIO_BACKEND}" --sink "${SINK_CHOICE}" --formats "${FORMATS}" --durations "${DURATIONS}" --loops "${LOOPS}" --timeout "${TIMEOUT}" --enable-network-download --ssid "${SSID}" --password "${PASSWORD}" || true |
Contributor
There was a problem hiding this comment.
Please remove the ssid and password from the yaml usage. Instead, allow the script to accept a custom location for the clips. The CI will push the content to a specified location, which can then be provided as a parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #229
Problem:
AudioPlayback test was forcing network connections even when audio files were already present locally, causing tests to fail in offline environments.
Solution: