Add libbsd support for non-Android builds and update CI workflows #279
+21
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-vkatoch
changed the title
lumag
reviewed
Jan 19, 2026
Contributor
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Commit message doesn't answer on the 'why?' question.
quic-mtharu
reviewed
Jan 19, 2026
lumag
approved these changes
Jan 20, 2026
Standard glibc does not provide BSD-specific string functions like strlcpy and strlcat, which are needed for safe string operations. Android includes these functions natively, but Linux GNU builds require an external library to provide them. Add dependency on libbsd-overlay for non-Android targets to provide the missing BSD functions. Configure the build system to detect and link against libbsd when building for Linux GNU platforms. Signed-off-by: Vinayak Katoch <vkatoch@qti.qualcomm.com>
Add libbsd-dev:arm64 to ARM64 workflows (build_linux_arm64.yml, codeql.yml, abi-compat.yml) and ensure libbsd-dev is in build_linux_gnu.yml to resolve configure errors during compilation. Signed-off-by: Vinayak Katoch <vkatoch@qti.qualcomm.com>
ekanshibu
approved these changes
Jan 20, 2026
quic-mtharu
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for libbsd on non-Android targets and export BSD_CFLAGS and BSD_LIBS. Include BSD flags in CFLAGS and link BSD libs alongside YAML libs.
Add libbsd-dev:arm64 to ARM64 workflows and ensure libbsd-dev is in build_linux_gnu.yml.
Technical Details
@BSD_CFLAGS@ adds the BSD include path (e.g.,
-isystem /usr/include/bsd). With libbsd-overlay, when<string.h>is included, the BSD header chain is pulled in indirectly through the overlay mechanism.As a result, the compiler sees the strlcpy/strlcat prototypes and no longer warns about implicit declarations, without requiring an explicit
#include <bsd/string.h>.Changes
Fixes: #265