Fix mink adaptor linkage to QCBOR and add deprecated TEEC error code #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minkadaptor library doesn't directly link to the qcbor library, which shifts the burden of linking to the client. This change fixes this problem by ensuring that the minkadaptor finds the qcbor package and links to it directly. At the same time, remove all links to the qcbor package from the clients of minkadaptor. Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
Added the deprecated TEEC_ERROR_EXTERNAL_CANCEL error code to TEE client API interface since some clients like xtest still depend on it. Signed-off-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minkadaptor library doesn't directly link to the qcbor library, which shifts the burden of linking to the client. Commit 1 fixes this issue.
Also, Added the deprecated TEEC_ERROR_EXTERNAL_CANCEL error code to TEE client API interface since some clients like OP-TEE xtest still depend on it. Commit 2 adds the error code.