chore: upgrade ts-client to v4. #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Quant TypeScript client from v3 to v4, simplifying authentication and removing custom API helper functions. The upgrade modernizes the codebase by replacing the GitHub-hosted quant-ts-client package with the npm-published @quantcdn/quant-client v4.0.0.
Key changes:
- Migration to
@quantcdn/quant-clientv4.0.0 with built-inConfigurationsupport - Simplified base URL to
https://dashboard.quantcdn.io(removed/api/v3path) - Removed custom
apiOpts()andremoveNullValues()helper functions
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/index.ts | Replaced custom authentication logic with v4 Configuration class; updated import statement and removed helper functions |
| package.json | Updated dependency from GitHub-hosted v3 to npm-published v4.0.0 |
| README.md | Updated usage examples to reflect v2 action version and new base URL format |
| CHANGELOG.txt | Added comprehensive changelog documenting v2.0.0 release with migration details |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const environmentName = core.getInput('environment_name', { required: true }); | ||
|
|
||
| const baseUrl = core.getInput('base_url') || 'https://dashboard.quantcdn.io/api/v3'; | ||
| let baseUrl = core.getInput('base_url') || 'https://dashboard.quantcdn.io'; |
There was a problem hiding this comment.
The variable baseUrl is declared with let but is never reassigned. Consider using const instead for better immutability and code clarity.
Suggested change
| let baseUrl = core.getInput('base_url') || 'https://dashboard.quantcdn.io'; | |
| const baseUrl = core.getInput('base_url') || 'https://dashboard.quantcdn.io'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.