feat: add HeliosConfig and Pecos noise model #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanyae-cqc
changed the title
chesterwringe
previously approved these changes
Oct 23, 2025
Contributor
chesterwringe
left a comment
chesterwringe
left a comment
There was a problem hiding this comment.
asking a few clarification comments - I imagine there's a stakeholder-based answer to my questions, but I wanted to double check. Approving either way, so you can make a release and get the mushroom PR ready
| | ClassicalReplaySimulator | ||
| ) = Field(default_factory=StatevectorSimulator) | ||
| error_model: ( | ||
| NoErrorModel | DepolarizingErrorModel | QSystemErrorModel | HeliosErrorModel |
Contributor
There was a problem hiding this comment.
If the intent of Helios-1E-lite is to be as close as possible to Helios, should all of these error models be available? Or should it just be HeliosErrorModel? Elsewise, what makes the difference between Helios-1E-lite and SelenePlus?
chesterwringe
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.