Skip to content

Conversation

@holly-cummins
Copy link
Contributor

A couple of times in the past few weeks I've tripped over the fact that the command codestart didn't have tests, and had to write some manually. This would be harder for people who didn't already know the structure of our testing framework.

@quarkus-bot quarkus-bot bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Oct 24, 2025
@quarkus-bot

This comment has been minimized.

@holly-cummins holly-cummins force-pushed the missing-command-codestart-tests branch from 7b4d2fb to d0cbaf5 Compare October 25, 2025 10:43
@quarkus-bot

This comment has been minimized.

@holly-cummins
Copy link
Contributor Author

If I'm reading develocity right, all those failing tests only failed in my CI. I don't see how my changes could cause that, so I'll rebase and try again.

@holly-cummins holly-cummins force-pushed the missing-command-codestart-tests branch from d0cbaf5 to b3d1b0f Compare October 27, 2025 17:08
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b3d1b0f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.devmode.IncludedKotlinKMPBuildDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes 30 seconds. - org.awaitility.core.ConditionTimeoutException
Details
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:165)

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Holly

@ia3andy ia3andy changed the title Add test to command quickstart Add test to command codestart Oct 29, 2025
@ia3andy ia3andy merged commit 25cd033 into quarkusio:main Oct 29, 2025
59 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.30 - main milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants