-
Notifications
You must be signed in to change notification settings - Fork 3k
Added class name check to remove warning #50722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aryant-Tripathi
wants to merge
81
commits into
quarkusio:main
Choose a base branch
from
Aryant-Tripathi:50572/fix-package-info-index-warning-in-hibernateormprocessor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
3c203fb
- Added class name check to remove warning that pckage cannot be inde…
Aryant-Tripathi b833f13
Fix package info index warning in hibernate orm processor
Aryant-Tripathi fd68642
Added class name check to remove warning that package cannot be index…
Aryant-Tripathi 2fe0271
Qute generator: fix multiple namespace extension methods
mkouba f2f0fb5
Bump io.quarkus.gizmo:gizmo2 from 2.0.0.Beta6 to 2.0.0.Beta8
dependabot[bot] e83711e
Bypass filters looking for a test class in the application module
aloubyansky f61a352
Bump com.google.errorprone:error_prone_annotations from 2.42.0 to 2.43.0
dependabot[bot] d0925a7
fix(ws-next): validate base URI scheme
michalvavrik 06ab0bb
ArC: fix subclass generation with not visible decorators
jonasrutishauser 3023296
ArC: add comments about decorators being interface-based
Ladicek 0040b6f
Reduce footprint of wiring classes generated by Gizmo 2
gsmet 91756cd
Intercept dev mode test instance for HTTP resource injection
MikeEdgar 25201f3
Ensure that FJP threads can load resources in tests
geoand c7b878e
Add comment about ForkJoinClassLoading#setForkJoinClassLoader
geoand 573a771
Hibernate HQL console: fix combo box for reactive/orm PUs with the sa…
mbellade 795141c
Jandex: upgrade to 3.5.1
Ladicek 3569463
Bump flyway.version from 11.14.1 to 11.15.0
dependabot[bot] a504778
Dev UI Agroal: add support for json cols
phillip-kruger 0d3395e
Reapply "Contain the use of reflection in amazon-lambda"
zakkak 9eb8296
Fix Amazon Lambda handler discovery fallback
zakkak 3e8012c
fix(test-security): Fix class-level @TestSecurity with method-level @…
michalvavrik cf20244
Bump io.strimzi:strimzi-test-container from 0.112.0 to 0.113.0
dependabot[bot] 55b3d5b
Add *.preferred_jdbc_type for instant, duration, boolean, UUID
NickBeginner 4acd473
OTel instrumentation 2.15.0-alpha, opentelemetry-semconv.version 1.32…
brunobat b0fdb6a
Add 3.27 as a guarded branch
gsmet 788b4ba
Update link and improve link text for WireMock
rolfedh cd13282
Dev UI: Remove global key press that cause issues
phillip-kruger 6670cfd
Bump org.quartz-scheduler:quartz from 2.5.0 to 2.5.1
dependabot[bot] 74f3ad8
Fix typo in error message for shutdownContext
GregJohnStewart 2656170
Make sure local quarkus-versions preferences are effective when the d…
aloubyansky 7be850c
Better validation funq function signature
matejvasek 202b4c3
Bump actions/upload-artifact from 4 to 5
dependabot[bot] 194edb6
Bump actions/download-artifact from 5 to 6
dependabot[bot] 7de7920
Make sure dev ui workspace don't prevent dev mode from starting up
phillip-kruger c3b4d8d
Add LGTM Observability codestart
alesj d87beba
Fix Liquibase `runCommand` in native mode
geoand 2906258
feat(oidc-token-propagation): add propagation for REST cl. methods
michalvavrik 0d2843b
Enhance CSRF prevention documentation
GregJohnStewart 2e7f396
Update docs/src/main/asciidoc/security-csrf-prevention.adoc
GregJohnStewart 999771b
updates from review
GregJohnStewart 672df7f
Record runtime configuration in its own ConfigSource
radcortez 058b7fe
Bump to Mutiny 3.0.1
jponge 65f407f
Bump the hibernate group with 8 updates
dependabot[bot] 17564d8
Mask some HTTP headers in the HTTP access log
sberyozkin b1f2272
Disable warnings about unsafe usage of Unsafe in native
zakkak a8a4190
Improve the code in security-oidc-bearer-token-authentication.adoc to…
jcarranzan ce05361
Avoid string creation
holly-cummins 234c81f
Bump to Vert.x 4.5.22
jponge e3e0b8d
Fix the Vert.x Redis client native compilation
jponge 131d7bc
Cover all Random static fields from vertx-redis-client in substitutions
jponge e9d1e56
Bump org.hibernate.tool:hibernate-tools-language in the hibernate group
dependabot[bot] 41e309e
Add test to command quickstart
holly-cummins b2acb6c
feat(ws-next): support OTel @SpanAttribute on endpoint callbacks
michalvavrik 2f9f1e5
Pass on container build arguments to Maven projects as arguments
galderz ccb8867
Fix Amazon Lambda handler method resolution
gsmet bf78cb7
Use an approach based on Jandex, as much as possible
gsmet fd62eaf
Reduce reflection requirements and simplify handling handlers
gsmet 5ac20db
feat(oidc-client-filter-reactive): make default client filter singleton
michalvavrik 44c590d
Redis Client: add sentinel topology cache TTL configuration
Ladicek bb1cfa0
Redis Client: deprecate hash-slot-cache-ttl and add topology-cache-ttl
Ladicek b931128
Only add quotes to channel name if required
radcortez 85f36b9
Add a tiny bit of javadoc
holly-cummins cf9b1bf
Bump org.apache.maven.plugins:maven-plugin-plugin from 3.15.1 to 3.15.2
dependabot[bot] ba27383
Add more information when class loader issue in tests
gsmet 86ea3f3
Change default password hashing algorithm to SHA-512
jcjveraa 3955d11
Fix OCP build and deploy command
rsvoboda 06261a5
Improve Docker and Podman CLI detection and error messages
gsmet 29b5b02
Update to slf4j-jboss-logmanager 2.0.2.Final
gsmet ea75990
ArC: introduce Arc.requireContainer()
mkouba d7197db
ArC: replace Arc.container() with Arc.requireContainer()
mkouba ebd7bbf
Registry client option to set a low boundary for recommended streams on
aloubyansky a57e9c8
Use Path.resolve to check for unknown configuration files
radcortez f041f7c
Avoid always displaying a warning about Java version
gsmet 9bd29fb
Propagate Java runtime version from project creation to function
gsmet 1a7f60a
Fix typo in error message
gsmet 8fce8ae
Make Azure messages at deployment a lot more readable
gsmet 720f194
Azure Functions documentation improvements
gsmet edd7a8f
Filter for client imports on class level only when discovering Endpoi…
sd-f b8454af
Update to the Quarkus Spring Data api 3.5 release
aureamunoz 59bc814
Added class name check to remove warning that package cannot be index…
Aryant-Tripathi fd70b63
Merge branch 'main' into 50572/fix-package-info-index-warning-in-hibe…
Aryant-Tripathi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
...loyment/src/test/java/io/quarkus/hibernate/orm/packages/PackageInfoNonRegressionTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| package io.quarkus.hibernate.orm.packages; | ||
|
|
||
| import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| import java.util.List; | ||
| import java.util.logging.Level; | ||
|
|
||
| import jakarta.inject.Inject; | ||
| import jakarta.persistence.EntityManager; | ||
| import jakarta.transaction.Transactional; | ||
| import jakarta.transaction.UserTransaction; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| import io.quarkus.hibernate.orm.TransactionTestUtils; | ||
| import io.quarkus.test.QuarkusUnitTest; | ||
|
|
||
| public class PackageInfoNonRegressionTest { | ||
|
|
||
| @RegisterExtension | ||
| static QuarkusUnitTest runner = new QuarkusUnitTest() | ||
| .withApplicationRoot((jar) -> jar | ||
| .addClass(TransactionTestUtils.class) | ||
| .addPackage(PackageInfoNonRegressionTest.class.getPackage()) | ||
| .addAsResource("application.properties")) | ||
| .setLogRecordPredicate(record -> record.getLevel().intValue() > Level.WARNING.intValue()) | ||
| .assertLogRecords(logs -> assertThat(logs).noneMatch( | ||
| log -> log.getMessage().contains("ClassLoader QuarkusClassLoader"))); | ||
|
|
||
| @Inject | ||
| EntityManager entityManager; | ||
|
|
||
| @Inject | ||
| UserTransaction transaction; | ||
|
|
||
| @Test | ||
| @Transactional | ||
| public void test() { | ||
|
|
||
| ParentEntity parent1 = new ParentEntity("parent1"); | ||
| entityManager.persist(parent1); | ||
|
|
||
| ParentEntity parent2 = new ParentEntity("parent2"); | ||
| entityManager.persist(parent2); | ||
|
|
||
| List<ParentEntity> entities = entityManager.createQuery("from ParentEntity ", ParentEntity.class).getResultList(); | ||
| assertEquals(2, entities.size()); | ||
|
|
||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update the
forloop above, to have an equivalent ofmanagedClassAndPackageNames.addAll(pud.getManagedClassNames());but for themanagedClassesNameset.Now, obviously you cannot use
pud.getManagedClassNames()for that, because that thing also returns package names. Which is where my comment should start to make sense: #50572 (comment)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I then believe sir, we have to add one more data member inside
QuarkusPersistenceUnitDescriptorclass, which only contains the classes name. We can take use of that data member in creating set of only managed class name.If it seems ok, may I proceed with those changes ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this seems perfectly reasonable :)