refactor(config): remove ADS MQTT topics, add stubs#116
Merged
q-soriarty merged 4 commits intodevelopfrom Feb 14, 2026
Merged
Conversation
Add PlcAdsState enum, PlcStateDto, AdsConnectionInfo, and AdsVariableSubscription to FlowForge.Shared for use across monitor and build server without requiring Beckhoff NuGet dependencies. Update PlcTargetDto with CurrentState and DeployRequestDto with AdsPort. Create doc/ADS_INTEGRATION.md documenting the decision to use direct Beckhoff.TwinCAT.Ads instead of custom MQTT ADS relay topics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add IAdsDeployClient/AdsDeployClient using Beckhoff.TwinCAT.Ads for deploy-time ADS operations (state read, config mode switch, restart). Update DeployStep with IAdsDeployClient + IAutomationInterface injection and documented deploy sequence. Add TargetConnectionInfo to BuildContext. Clarify MqttHandler is for FlowForge internal messaging only. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace IMqttAdsClient/MqttAdsClient with IAdsClient/AdsClientWrapper using Beckhoff.TwinCAT.Ads + TcpRouter for direct ADS-over-TCP from Linux Docker containers. Add batch read (Sum Commands), PLC state read, and ADS notification subscription to the interface. Update PlcDataHub to use IAdsClient with SubscriptionManager. Add ADS connection config (TargetHostname, AdsPort, AdsTcpPort) to MonitorOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove AdsRead/AdsWrite/AdsNotification MQTT topics — ADS communication now uses Beckhoff.TwinCAT.Ads directly. Add DeployStatus topic for deploy progress. Update DeployService with IMqttService dependency and TODO stubs for deploy request/approval/status. Add TODO stubs to TargetService for target listing, deploy lock, and permission checks. Create BUILD_SERVER_DESIGN.md and MODULE_ARCHITECTURE.md. Update ARCHITECTURE.md to reflect ADS-direct architecture throughout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdsRead(),AdsWrite(),AdsNotification()fromMqttTopics.cs— ADS is now directDeployStatus(Guid deployId)MQTT topic for deploy progress notificationsDeployServicewithIMqttServiceand TODO stubs (request, approve, get status)TargetServicewith TODO stubs (list targets, deploy lock, deploy permission check)doc/BUILD_SERVER_DESIGN.mdanddoc/MODULE_ARCHITECTURE.mdwith ADS-direct architecturedoc/ARCHITECTURE.mdto replace all "ADS over MQTT" referencesDependencies
feature/ads-monitor-server) and feat(build-server): add ADS deploy client #115 (feature/ads-build-server)Test plan
dotnet build src/FlowForge.slncompiles (0 warnings, 0 errors)dotnet test src/FlowForge.slnpasses all tests🤖 Generated with Claude Code